Remove deprecation warnings in test #1416
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinjqliu
commented
Dec 7, 2024
| @@ -56,7 +56,6 @@ def deprecation_message(deprecated_in: str, removed_in: str, help_message: Optio | |||
|
|
|||
| def _deprecation_warning(message: str) -> None: | |||
| with warnings.catch_warnings(): # temporarily override warning handling | |||
| warnings.simplefilter("always", DeprecationWarning) # turn off filter | |||
There was a problem hiding this comment.
removing this setting, otherwise there's no way to override a warning
|
@kevinjqliu can you rebase this one? :) |
Deprecated in 0.8.0, will be removed in 0.9.0. Parsing expressions with table name is deprecated. Only provide field names in the row_filter.
Deprecated in 0.8.0, will be removed in 1.0.0. Iceberg REST client is missing the OAuth2 server URI configuration
kevinjqliu
force-pushed
the
kevinjqliu/remove-deprecation-warnings-in-test
branch
from
d4d9c79 to
a5d4d0c
Compare
|
done! @Fokko can you take another look? ran locally no warnings in |
Fokko
reviewed
Dec 20, 2024
| @@ -70,7 +70,6 @@ def test_equals_false() -> None: | |||
| def test_is_null() -> None: | |||
| assert IsNull("foo") == parser.parse("foo is null") | |||
| assert IsNull("foo") == parser.parse("foo IS NULL") | |||
| assert IsNull("foo") == parser.parse("table.foo IS NULL") | |||
There was a problem hiding this comment.
@kevinjqliu Was this one intentional?
There was a problem hiding this comment.
yep! its associated with this one
iceberg-python/pyiceberg/expressions/parser.py
Lines 90 to 100 in dbcf65b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing deprecation warnings emitted during pytests. This will also prepare us for
0.9.0releaseFix these errors in
make-test:tests/catalog/test_rest.pyDeprecated in 0.8.0, will be removed in 1.0.0. Iceberg REST client is missing the OAuth2 server URI configurationtests/expressions/test_parser.py::test_is_nullDeprecated in 0.8.0, will be removed in 0.9.0. Parsing expressions with table name is deprecated. Only provide field names in the row_filter.