Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-7028][CH][Part-12] Add Local SortExec for Partition Write in one pipeline mode #8237

Merged
merged 6 commits into from
Dec 17, 2024

Conversation

baibaichen
Copy link
Contributor

@baibaichen baibaichen commented Dec 15, 2024

What changes were proposed in this pull request?

Since Clickhouse backend doesn't add local sort by itself, this is differnet with velox backend. This PR and Local SortExec based on SparkPlan instead of LogicalPlan for Delta Write and remove RemoveNativeWriteFilesSortAndProject for datasource v1 write.

  1. I also fix an issue caused by WriteRel doesn't including partition column order issue by adding such information in write_optimization.proto
  2. Since we already sort blocks, hence we can removeApplySquashingTransform and PlanSquashingTransform from pipeline and adding Squashing in SparkMergeTreeSink.

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

@github-actions github-actions bot added CORE works for Gluten Core VELOX CLICKHOUSE labels Dec 15, 2024
Copy link

#7028

Copy link

Run Gluten Clickhouse CI on x86

@baibaichen baibaichen force-pushed the feature/Add_LocalSort branch from 9efdeaf to 41e669b Compare December 15, 2024 09:26
Copy link

Run Gluten Clickhouse CI on x86

@baibaichen baibaichen force-pushed the feature/Add_LocalSort branch from 41e669b to d9b870a Compare December 15, 2024 13:44
Copy link

Run Gluten Clickhouse CI on x86

@baibaichen baibaichen force-pushed the feature/Add_LocalSort branch from d9b870a to 633eee9 Compare December 16, 2024 03:37
Copy link

Run Gluten Clickhouse CI on x86

@baibaichen baibaichen marked this pull request as ready for review December 16, 2024 03:48
@baibaichen baibaichen merged commit c1d66c4 into apache:main Dec 17, 2024
49 checks passed
@baibaichen baibaichen deleted the feature/Add_LocalSort branch December 17, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLICKHOUSE CORE works for Gluten Core VELOX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants