-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLUTEN-7028][CH][Part-15] [MINOR] Fix UTs #8364
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run Gluten Clickhouse CI on x86 |
11 tasks
baibaichen
force-pushed
the
feature/fixut
branch
from
December 28, 2024 13:45
cc48ef6
to
3e93ed5
Compare
Run Gluten Clickhouse CI on x86 |
zzcclp
approved these changes
Dec 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixed 3 UTs
GlutenClickHouseMergeTreeCacheDataSuite::test cache mergetree data no partition columns
, it's fixed by [GLUTEN-7028][CH][Part-14] Refactor Case Sensitive Support for MergeTree #8346, just reopen testGlutenClickHouseMergeTreePathBasedWriteSuite::test mergetree path based table update
andGlutenClickHouseMergeTreePathBasedWriteSuite::test mergetree path based table delete
, since one pipeline write will collect stats, so that pruning will be more accurate in point query, addingwithSQLConf(("spark.databricks.delta.stats.skipping", "false"))
to make test suucess.test mergetree with partition with whitespace
, whitespace will be saved as%20
in Delta commit protocol, so that we need follow this, and hence decode it to normal string in backend.(Fixes: #7028)
How was this patch tested?
Existed ignore uts