KAFKA-16339: [Docs] Add migrating from transform to process #18314
Conversation
Signed-off-by: Joao Pedro Fonseca Dantas <[email protected]>
There was a problem hiding this comment.
Thanks for the PR. Made a first pass. The comments apply to all examples.
We should also delete the removed methods from the table in the "PAPI integration" section: https://kafka.apache.org/39/documentation/streams/developer-guide/dsl-api.html#applying-processors-and-transformers-processor-api-integration
|
|
||
| // After | ||
| KStream<String, String> processedStream = stream.process( | ||
| () -> new CustomProcessor(), |
There was a problem hiding this comment.
It seems switching from KStream#transform() to KStream#process() is the easy part. I guess the more interesting question is, how to rewrite CustomTransformer to CustomProcessor() ?
|
|
||
| // After | ||
| KStream<String, String> processedStream = stream.process( | ||
| () -> new Processor<String, String>() { |
There was a problem hiding this comment.
New new api.Processor has 4 generic, key/value in/out.
| KStream<String, String> processedStream = stream.process( | ||
| () -> new Processor<String, String>() { | ||
| @Override | ||
| public void init(ProcessorContext context) { |
There was a problem hiding this comment.
The new api.ProcessorContext has <KOut, VOut> generic types.
| () -> new Processor<String, String>() { | ||
| @Override | ||
| public void init(ProcessorContext context) { | ||
| // Initialization logic here |
There was a problem hiding this comment.
Might be good to just fill in the code? We need to store a reference to context
| } | ||
|
|
||
| @Override | ||
| public void process(String key, String value) { |
There was a problem hiding this comment.
| public void process(String key, String value) { | |
| public void process(Record<String, String> record) { |
|
|
||
| @Override | ||
| public void process(String key, String value) { | ||
| Iterable<KeyValue<String, String>> results = customFlatTransformation(key, value); |
There was a problem hiding this comment.
I think it would be difficult for user to reason what customFlatTransformation is?
| public void process(String key, String value) { | ||
| Iterable<KeyValue<String, String>> results = customFlatTransformation(key, value); | ||
| for (KeyValue<String, String> result : results) { | ||
| context.forward(result.key, result.value); |
| } | ||
|
|
||
| @Override | ||
| public void close() { |
| <ul> | ||
| <li><strong>Unified API:</strong> Consolidates multiple methods into a single, versatile API.</li> | ||
| <li><strong>Flexibility:</strong> Simplifies the implementation of custom processing logic.</li> | ||
| <li><strong>Future-Proof:</strong> Ensures compatibility with the latest Kafka Streams releases.</li> |
There was a problem hiding this comment.
I would add "Improved type-safty" that the "new PAPI" offers.
|
@mjsax, may I format the code? Some blocks are not indented properly. I understand it might pollute the diff in code changes, so if I may, I would do it as a final commit. |
No description provided.