KAFKA-15370: Support Participation in 2PC (KIP-939) (2/N) #18316
+20
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update producer id request / response formats and transaction log value formwat. There is no functional change.
github-actions
bot
added
triage
jolshan
reviewed
Dec 25, 2024
| "about": "The current epoch associated with the producer id." }, | ||
| { "name": "OngoingTxnProducerId", "type": "int64", "versions": "6+", "entityType": "producerId", | ||
| "default": -1, "about": "The producer id for ongoing transaction when KeepPreparedTxn is used, -1 if there is no transaction ongoing." }, | ||
| { "name": "OngoingTxnProducerEpoch", "type": "int16", "versions": "6+", |
There was a problem hiding this comment.
Did we want to explicitly set the default to -1 for both?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update producer id request / response formats and transaction log value format. There is no functional change.