Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush at exit #281

Merged
merged 8 commits into from
Nov 9, 2023
Merged

Flush at exit #281

merged 8 commits into from
Nov 9, 2023

Conversation

vopl
Copy link
Contributor

@vopl vopl commented Nov 5, 2023

Flushing all buffered data during the static deinitialization phase.

@rm5248
Copy link
Contributor

rm5248 commented Nov 6, 2023

Shouldn't LogManager::shutdown do the proper flushing of data? Or does that not work under certain situations?

@vopl
Copy link
Contributor Author

vopl commented Nov 6, 2023

Shouldn't LogManager::shutdown do the proper flushing of data? Or does that not work under certain situations?

LogManager::shutdown terminates logger functionality, but this case about events-at-exit, in which all logger functionality should continue to work

@swebb2066
Copy link
Contributor

Perhaps you also could include SocketOutputStream and ODBCAppender?

@vopl
Copy link
Contributor Author

vopl commented Nov 7, 2023

I can't support SocketOutputStream, it doesn't have enough internal infrastructure for flushing, in particular, there is no apr-Pool instance, which is placed in more derived types. (It's not actually used for flushing, but I don't able to make a second layer of stubs)

@swebb2066
Copy link
Contributor

swebb2066 commented Nov 8, 2023

I can't support SocketOutputStream

OK, but as XMLSocketAppender calls flush() in each append(), I suggest the change XMLSocketAppender is not required.

@rm5248 rm5248 merged commit 24edf07 into apache:master Nov 9, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants