[MSHARED-1347] Include invoke dynamic bootstrap types in analysis #102
Conversation
|
@vbreivik please fix formatting issues |
Test case to recreate issue requires two packages since ClassFileVisitorUtils does not accept single files, only jars and directories.
vbreivik
force-pushed
the
MSHARED-1347/invokedynamic
branch
from
5712832 to
542de24
Compare
@slawekjaranowski done. Guess spotless tricked me, it does not run on java 8. |
| @@ -157,4 +160,14 @@ private void addTypeSignature(final String signature) { | |||
| new SignatureReader(signature).acceptType(signatureVisitor); | |||
| } | |||
| } | |||
|
|
|||
| @Override | |||
| public void visitInvokeDynamicInsn( | |||
There was a problem hiding this comment.
Insn --> Instruction
I had to think about this one to figure it out.
In general, avoid abbreviations
There was a problem hiding this comment.
The naming is controlled by ASM. This class extends MethodVisitor from ASM.
| @@ -40,4 +43,12 @@ void test() throws Exception { | |||
|
|
|||
| assertThat(result).isNotEmpty(); | |||
| } | |||
|
|
|||
| @Test | |||
| void verify_implicit_class_reference_included_in_used_classes() throws IOException { | |||
There was a problem hiding this comment.
naming convention seems wonky here
There was a problem hiding this comment.
Snake case is a habit, I find it more readable. I have no strong opinions. If it should be changed to camelCase then let me know and I will update.
Please also check if my logic is sound. I am no expert in ASM and byte code. Naming is easily fixed.
elharo
changed the title
After this change the test case added to the issue MDEP-576: dependency-plugin-vs-java-lambda passes OK.
The above test is reproduced in a smaller scale by creating two classes in their own packages and analyse the one package.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes. Also be sure having selected the correct component.
[MSHARED-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MSHARED-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.