Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASCII digits only for versions #652

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

ASCII digits only for versions #652

wants to merge 7 commits into from

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Feb 10, 2025

Everything else is treated alphabetically.

@cstamas
Copy link
Member

cstamas commented Feb 10, 2025

Pls don't forget spec, change it as well if you do updates to implementation that maybe needs to go there as well:
https://github.com/apache/maven-resolver/blob/master/maven-resolver-util/src/main/java/org/eclipse/aether/util/version/package-info.java

@cstamas
Copy link
Member

cstamas commented Feb 10, 2025

@dmlloyd ping

@elharo elharo requested a review from gnodet February 10, 2025 14:14
@elharo
Copy link
Contributor Author

elharo commented Feb 10, 2025

Addition to spec (not change as we never actually specified this) is waiting for review in apache/maven-site#661

@cstamas
Copy link
Member

cstamas commented Feb 10, 2025

Well, let me just explain:

  • Maven2 had version implementation, that in Maven3 was moved to maven-artifact
  • Maven3 also introduced Maven Resovler that ALSO implemented version
  • in Maven3 "universe" there are 2 parallel (and literally duplicate) implementations, and Resolver is the "right thing" (as all the plugins moved to use it, see https://cwiki.apache.org/confluence/display/MAVEN/Maven+Ecosystem+Cleanup)
  • In Maven4 (due compatibility for mvn3) the maven-artifact is still there, but yet another Maven4 API for Versions are introduced, that are fully delegating to Resolver Version.

And similar mess exists in doco. What we tried here in "spec" to have one formal spec, as Maven site and plugins all over the place do have some "sort of doco" about it, but not was complete and formal.

Hence, same effort should be done on site as well, to have one spec, one thing documented, and not multiple (many times contradicting or incomplete) pages about the same thing.

@dmlloyd
Copy link

dmlloyd commented Feb 10, 2025

As what one might refer to as a "frequent complainer" when it comes to the version scheme, I think this change seems reasonable and shouldn't negatively impact anything that I'm aware of.

@elharo elharo marked this pull request as ready for review February 10, 2025 20:25
Copy link
Contributor Author

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I was unaware of the package.info spec. I added these cases to it.

@elharo elharo requested a review from cstamas February 11, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants