-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASCII digits only for versions #652
base: master
Are you sure you want to change the base?
Conversation
Pls don't forget spec, change it as well if you do updates to implementation that maybe needs to go there as well: |
@dmlloyd ping |
Addition to spec (not change as we never actually specified this) is waiting for review in apache/maven-site#661 |
Well, let me just explain:
And similar mess exists in doco. What we tried here in "spec" to have one formal spec, as Maven site and plugins all over the place do have some "sort of doco" about it, but not was complete and formal. Hence, same effort should be done on site as well, to have one spec, one thing documented, and not multiple (many times contradicting or incomplete) pages about the same thing. |
As what one might refer to as a "frequent complainer" when it comes to the version scheme, I think this change seems reasonable and shouldn't negatively impact anything that I'm aware of. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I was unaware of the package.info spec. I added these cases to it.
Everything else is treated alphabetically.