mcu/nordic: Set flags before running SPI callback #3133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a non-blocking SPI transfer has finished, our `spi->spi_xfr_flag` and the hardware interrupt flag are now reset before the `spi->txrx_cb_func` is run. This allows the callback to start a new SPI transfer.
kasjer
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a non-blocking SPI transfer has finished, our
spi->spi_xfr_flagand the hardware interrupt flag are now reset before thespi->txrx_cb_funcis run. This allows the callback to start a new SPI transfer.I've tested the nRF52 changes and they're fine. I'm making the bold assumption that the other nRFs work the same.