console: Fix console history placement #3140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Console history was meant to be stored in section pointed by bssnz_t This section is usually defined in bsp.h that was not included. Section was put in normal ram and console history was not able to persist across reboots as was the intentions. Now bsp.h is included and console history can be accessed after reboot if bsp defines section that is not cleared during startup. Signed-off-by: Jerzy Kasenberg <[email protected]>
sjanc
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Console history was meant to be stored in section pointed by bssnz_t This section is usually defined in bsp.h that was not included. Section was put in normal ram and console history was not able to persist across reboots as was the intentions.
Now bsp.h is included and console history can be accessed after reboot if bsp defines section that is not cleared during startup.