Few small pic32 fixes #3165
Merged
Few small pic32 fixes #3165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kasjer
commented
Mar 15, 2024
kasjer
commented
- I2C_4 was incorrectly initialized
- added missing hal_gpio_deinit() function
- added support for link_tables.ld.h
- fix of .sdata2 section placement
One of hal_gpio functions was not implemented and now it is added like for other MCU's Signed-off-by: Jerzy Kasenberg <[email protected]>
This add support for link tables. Linker script now includes newt generated include file into .rodata section. Signed-off-by: Jerzy Kasenberg <[email protected]>
.sdata2. section is meant to be placed in RAM not in flash. Now .sdata2 has no destination specified and is manged by linker internally. Signed-off-by: Jerzy Kasenberg <[email protected]>
For I2C_4 (if enabled) configuration was using i2c_3_cfg data instead of i2c_4_cfg, it is now corrected. Signed-off-by: Jerzy Kasenberg <[email protected]>
sjanc
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.