tinyusb/msc_fat_view: Make application version optional in readme #3181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated README.TXT file contains line App version: 1.2.1.2 This line is generated from image version from SLOT0. This line uses fprintf and can increase code size if printf-like functions were not otherwise used. Now syscfg value MSC_FAT_VIEW_DEFAULT_README_VERSION can disable line with version possibly reducing code size. Additionally default application name used in README.TXT is taken from APP_NAME syscfg value generated by newt tool. Signed-off-by: Jerzy Kasenberg <[email protected]>
sjanc
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generated README.TXT file contains line
App version: 1.2.1.2
This line is generated from image version from SLOT0. This line uses fprintf and can increase code size if printf-like functions were not otherwise used.
Now syscfg value MSC_FAT_VIEW_DEFAULT_README_VERSION can disable line with version possibly reducing code size.
Additionally default application name used in README.TXT is taken from APP_NAME syscfg value generated by newt tool.