Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-14089 Add MethodsEndpointUrlPrefix Property to PublishSlack Processor #9586

Closed
wants to merge 1 commit into from

Conversation

ryostaka
Copy link

Summary

NIFI-14089

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@joewitt
Copy link
Contributor

joewitt commented Dec 31, 2024

change looks good - anybody familiar with the Slack api able to review?

Copy link
Contributor

@Lehel44 Lehel44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryostaka Thanks for the contribution. I reviewed the changes and tested it on a custom slack app with nginx proxy. Looks good to me!

@Lehel44 Lehel44 closed this in 547f101 Jan 8, 2025
@Lehel44
Copy link
Contributor

Lehel44 commented Jan 8, 2025

LGTM+1 merged to main.

@ryostaka
Copy link
Author

ryostaka commented Jan 9, 2025

@joewitt @Lehel44
Thank you for reviewing and merging!

@ryostaka ryostaka deleted the NIFI-14089 branch January 9, 2025 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants