Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-14100: Add option to sequential download of dependencies for Pyt… #9589

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Lehel44
Copy link
Contributor

@Lehel44 Lehel44 commented Dec 20, 2024

…hon processors

Summary

NIFI-14100

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lehel44 Thanks for highlighting this issue, but I don't think the proposed approach is a good way forward.

This is not something an administrator should have to configure, and we should avoid introducing new configuration properties if we can implement better behavior in general.

There are inherent limitations with automatic dependency downloads for Python, which is one of the reasons for introducing Python-based NAR bundling. That should be the solution for resource-constrained environments.

We may be able to improve download behavior by replacing pip with uv, although that is a system requirement to consider.

As it stands, we should further consider the options before pursuing the current approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants