NIFI-14109 Refactored remaining processors and control services to be uniform when creating properties and relationships. #9600
Conversation
… uniform when creating properties and relationships.
| relationships.addAll(getAdditionalRelationships()); | ||
| this.relationships = Collections.unmodifiableSet(relationships); | ||
| this.descriptors = Stream.concat( | ||
| PROPERTIES.stream(), |
There was a problem hiding this comment.
Is there no simpler/cleaner option than Stream.concat ... list.stream().... .toList()? Overall this is cleanear in some ways but does seem like there is a cleaner/simpler way of saying 'List from these lists'
| @@ -143,7 +143,7 @@ public class AzureEventHubRecordSink extends AbstractControllerService implement | |||
|
|
|||
| @Override | |||
| protected List<PropertyDescriptor> getSupportedPropertyDescriptors() { | |||
| return PROPERTY_DESCRIPTORS; | |||
| return PROPERTIES; | |||
There was a problem hiding this comment.
As I look through here it is clearly inconsistent whether we use the term properties, descriptors, or property descriptors. However, we should be careful. These things we're messing with in all these files are PropertyDescriptor objects. They're not actually properties. If we're going to establish more consistency we should consider using the term DESCRIPTOR or PROPERTY_DESCRIPTOR but probably not simply PROPERTIES
| AMQP_VERSION, | ||
| SSL_CONTEXT_SERVICE, | ||
| USE_CERT_AUTHENTICATION | ||
| ); |
There was a problem hiding this comment.
Here the parent class 'getCommonPropertyDescriptors' method is removed and instead a subclass is supposed to know to use the static list of descriptors as they build their own lists. I think this weakens what the author intended in building that class.
Also there is at least one example much later on in this PR where you kept the parent method. I think keeping the parent method better conveys intent to any subclassers.
Summary
NIFI-14109
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation