[core] Optimize snapshotManager code eliminate duplicate logic. #4827
+283
−127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwj6591812
reviewed
Jan 3, 2025
| return null; | ||
| } | ||
|
|
||
| private @Nullable Long binarySearch( |
There was a problem hiding this comment.
Could you add a ut to test this method?
There was a problem hiding this comment.
Could you add a ut to test this method?
fixed
herefree
force-pushed
the
optimizesnaphotmanager
branch
from
8e7780e to
6fea091
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
There are some duplicate binarySearch codes in different method.Extract into a common binarySearch method.
Linked issue: close #xxx
Tests
API and Format
Documentation