Cache output of assembly #1125
Merged
Cache output of assembly #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the build would rebuild over and over the uber jar with the shaded protobuf3 distribution. With this patch, this is no longer the case, as the output is cached locally.
|
relates to #1008 |
|
Thanks for the PR, @Roiocam fyi this is precisely what I was talking about earlier wrt sbt's inbuilt caching functionality |
mdedetrich
approved these changes
Feb 17, 2024
There was a problem hiding this comment.
lgtm but lets get approval from @Roiocam before merging to double check nothing is amiss.
|
Thanks for the PR then, merging! |
This was referenced Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the build would rebuild over and over the uber jar with the
shaded protobuf3 distribution. With this patch, this is no longer the
case, as the output is cached locally.
The issue with assembly re-creating the same uber-jar on (nearly) every run was discovered using the Develocity Timeline feature, which displays task executions on different swimlanes.
Before this fix, the assembly task is clearly shown as being a bottleneck in the build process:
After this patch is applied, the bottleneck is gone:
After the bottleneck is gone, common tasks (eg.
test) start faster: Gathering all tests’ names goes from 3.7s to 3.2s (-15%).