PHOENIX-7107 Add support for indexing on SYSTEM.CATALOG table #2048
+1,153
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadirozde
reviewed
Jan 13, 2025
| import static org.apache.phoenix.util.ViewIndexIdRetrieveUtil.NULL_DATA_TYPE_VALUE; | ||
| import static org.apache.phoenix.util.ViewIndexIdRetrieveUtil.VIEW_INDEX_ID_BIGINT_TYPE_PTR_LEN; | ||
|
|
||
| /** |
There was a problem hiding this comment.
Comments here are for the PHOENIX_ROW_TIMESTAMP() function. Let's update them.
kadirozde
reviewed
Jan 13, 2025
| SortOrder.ASC); | ||
| } | ||
|
|
||
| System.out.println("DecodeViewIndexIdFunction: Type: " + type); |
There was a problem hiding this comment.
Let's remove the debug line here
|
@kadirozde Final PR, please review once more. Thanks |
|
@tkhurana @virajjasani The UpsertSelectIT test are failing on connLeak checks. I remember this being a flapper in the past? |
|
It used to be flakes sometimes but it never used to fail consistently. Is it consistently failing now? |
|
They failed in 2 consecutive runs. Also there are some backward compatibility test failures. Will look into it when I come back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.