-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade AWS SDK to 2.30; update tests to disable default integrity protection #14909
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14909 +/- ##
============================================
+ Coverage 61.75% 63.72% +1.97%
- Complexity 207 1469 +1262
============================================
Files 2436 2708 +272
Lines 133233 151423 +18190
Branches 20636 23376 +2740
============================================
+ Hits 82274 96498 +14224
- Misses 44911 47672 +2761
- Partials 6048 7253 +1205
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this! Can you help also double check if the usage of S3Client
in S3PinotFS
won't be affected?
This is only an issue when the new client is used with an S3 server that doesn't support this data integrity protection feature (https://aws.amazon.com/blogs/aws/introducing-default-data-integrity-protections-for-new-objects-in-amazon-s3/). So this won't be a problem for users using it with Amazon S3 itself. Do we recommend / support using this same |
I don't think so. It is fine as long as it works with Amazon S3. |
S3PinotFSTest
- Bump software.amazon.awssdk:bom from 2.29.52 to 2.30.4 #14907, Bump software.amazon.awssdk:bom from 2.29.52 to 2.30.0 #14825.