-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: massive theming-related PR #31590
Draft
mistercrunch
wants to merge
27
commits into
master
Choose a base branch
from
template_less
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
mistercrunch
force-pushed
the
template_less
branch
2 times, most recently
from
December 24, 2024 04:49
f1c7929
to
43452ff
Compare
mistercrunch
force-pushed
the
template_less
branch
from
December 28, 2024 01:08
97e182d
to
0655910
Compare
mistercrunch
changed the title
feat: feat(less): templatize .less files to reference main theme
feat: feat(less): massive theming-related PR
Dec 30, 2024
mistercrunch
changed the title
feat: feat(less): massive theming-related PR
feat: massive theming-related PR
Dec 30, 2024
mistercrunch
force-pushed
the
template_less
branch
from
December 30, 2024 15:43
1ca8e6e
to
6c6532e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excuse the large PR, but this is fairly tangled up, and working on fixing up theming probably requires some massive PRs as it's really hard to proceed PR-by-PR - especially during the holiday break...
Introducing less handlebars templates
First. Clearly we should move away from
less
and commit to emotion/antd for theming Now deleting the less files is going to be difficult. In the meantime, I wanted to provide a way for less files to source from the main theme object. I decided to go with handlebars since that should be part of the build process.Considerations:
.less
files from the repo, and make sure they are dynamically generated on every builds. In the meantime I thought I'd leave them here, and we can instruct people to alter.less.hds
files and runnpm run compile-less
on demand, if/when altering the main themeLarge refactor - what's in this PR?
antd
theme tokenswhat's NOT in this PR? - yet to come
theme.antd
referencing in emotionThemeConfig
as the theme setup, this will require more moving from legacy theme object to antd