Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(urlParam): new locale urlparam embedding to setup language for traductions #31646

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ERGO1995
Copy link

SUMMARY

I picked up an existing PR that was no longer progressing (PR 30318). The idea is to make the language dynamic and configurable in the context of embedding a dashboard. To achieve this, I added a "locale" key in the urlParams, which allows passing the desired language code. Thus, in an embedding context, you just need to manage this code dynamically so that the user can view the dashboards in their preferred language.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

locale: 'en' :
Capture d’écran 2024-12-30 à 17 09 44

locale: 'fr'
Capture d’écran 2024-12-30 à 17 08 58

TESTING INSTRUCTIONS

You can modify the "locale" key here:

<script>
    supersetEmbeddedSdk.embedDashboard({{
        id: "{dashboard_uuid}",
        supersetDomain: "{SUPERSET_URL}",
        mountPoint: document.getElementById("dashboard-container"),
        fetchGuestToken: () => "{token}",
        dashboardUiConfig: {{
            hideTitle: true,
            hideChartControls: false,
            urlParams: {{
                startDate: '2024-01-01T00:00:00',
                endDate: '2024-12-31T23:59:59',
                locale: 'en'
            }}
        }}
    }});
</script>

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the api Related to the REST API label Dec 30, 2024
@dosubot dosubot bot added change:frontend Requires changing the frontend i18n:general Related to translations labels Dec 30, 2024
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues... but I did find this horse.

            .''
  ._.-.___.' (`\
 //(        ( `'
'/ )\ ).__. )
' <' `\ ._/'\
   `   \     \
Files scanned
File Path Reviewed
superset/app.py
superset-frontend/src/components/Loading/index.tsx
superset-frontend/src/constants.ts
superset/views/base.py
superset/views/core.py
superset/config.py

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

  • You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
  • You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
  • Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
  • Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
  • Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

  • Check out our docs on how you can make Korbit work best for you and your team.
  • Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings
Setting Value
Review Schedule Automatic excluding drafts
Max Issue Count 10
Automatic PR Descriptions
Issue Categories
Category Enabled
Naming
Database Operations
Documentation
Logging
Error Handling
Systems and Environment
Objects and Data Structures
Readability and Maintainability
Asynchronous Processing
Design Patterns
Third-Party Libraries
Performance
Security
Functionality

Feedback and Support

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Related to the REST API change:frontend Requires changing the frontend i18n:general Related to translations size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant