Skip to content

Commit

Permalink
Update readme and workflow
Browse files Browse the repository at this point in the history
  • Loading branch information
alisnic committed Mar 14, 2022
1 parent 63d0cfc commit 6b7c65d
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 4 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,7 @@ jobs:
run: (cd spec/rails5; bundle install; yard gems)
- name: Install Rails 6 deps
run: (cd spec/rails6; bundle install; yard gems)
- name: Install Rails 7 deps
run: (cd spec/rails7; bundle install; yard gems)
- name: Run tests
run: bundle exec rspec
16 changes: 12 additions & 4 deletions DEVELOPMENT.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,16 @@
$ bundle install && yard gems
$ cd ../../
```
4. now tests should pass locally and you can try different changes
5. sumbit PR
4. install dummy rails7 app deps and build its yard cache
```
$ cd spec/rails7
$ bundle install && yard gems
$ cd ../../
```
5. now tests should pass locally and you can try different changes
6. sumbit PR
## Completion coverage tracking
Expand Down Expand Up @@ -74,10 +82,10 @@ In case of option 2, don't forget to remove the flag after yml file has been upd

In case a new set of assertion files has to be created (for a new Rails version for example), a script can be used - https://github.com/iftheshoefritz/solargraph-rails/blob/master/script/generate_definitions.rb.

All you have to do is to go to the same Rails app root, and execute the script:
All you have to do is execute the script and pass it a path to rails app:

```
ruby path/to/generate_definitions.rb
ruby script/generate_definitions.rb spec/rails6
```

Make sure to review the script and uncomment relevant parts

0 comments on commit 6b7c65d

Please sign in to comment.