Skip to content

Commit

Permalink
Merge pull request iftheshoefritz#49 from iftheshoefritz/unversioned-…
Browse files Browse the repository at this point in the history
…solargraph

Remove the pinned version on solargraph dependency
  • Loading branch information
iftheshoefritz authored Dec 2, 2022
2 parents 7d386b5 + 3c4b6a7 commit c7a2dc4
Show file tree
Hide file tree
Showing 14 changed files with 30 additions and 24 deletions.
2 changes: 1 addition & 1 deletion solargraph-rails.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,6 @@ Gem::Specification.new do |spec|
spec.add_development_dependency 'rake', '~> 12.3.3'
spec.add_development_dependency 'rspec', '~> 3.0'

spec.add_runtime_dependency 'solargraph', '~> 0.44.2'
spec.add_runtime_dependency 'solargraph'
spec.add_runtime_dependency 'activesupport'
end
2 changes: 1 addition & 1 deletion spec/definitions/rails5/activejob.yml
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ ActiveJob::Base.deprecate:
ActiveJob::Base.descendants:
types:
- undefined
skip: false
skip: true
ActiveJob::Base.deserialize:
types:
- undefined
Expand Down
2 changes: 1 addition & 1 deletion spec/definitions/rails5/core/Array.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ Array.deprecate:
Array.descendants:
types:
- undefined
skip: false
skip: true
Array.duplicable?:
types:
- undefined
Expand Down
4 changes: 2 additions & 2 deletions spec/definitions/rails5/core/Class.yml
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ Class.deprecate:
Class.descendants:
types:
- undefined
skip: false
skip: true
Class.duplicable?:
types:
- undefined
Expand Down Expand Up @@ -313,7 +313,7 @@ Class#deprecate:
Class#descendants:
types:
- undefined
skip: false
skip: true
Class#duplicable?:
types:
- undefined
Expand Down
2 changes: 1 addition & 1 deletion spec/definitions/rails5/core/Date.yml
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ Date.deprecate:
Date.descendants:
types:
- undefined
skip: false
skip: true
Date.duplicable?:
types:
- undefined
Expand Down
2 changes: 1 addition & 1 deletion spec/definitions/rails5/core/DateTime.yml
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ DateTime.deprecate:
DateTime.descendants:
types:
- undefined
skip: false
skip: true
DateTime.duplicable?:
types:
- undefined
Expand Down
2 changes: 1 addition & 1 deletion spec/definitions/rails5/core/File.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ File.deprecate:
File.descendants:
types:
- undefined
skip: false
skip: true
File.duplicable?:
types:
- undefined
Expand Down
2 changes: 1 addition & 1 deletion spec/definitions/rails5/core/Hash.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ Hash.deprecate:
Hash.descendants:
types:
- undefined
skip: false
skip: true
Hash.duplicable?:
types:
- undefined
Expand Down
2 changes: 1 addition & 1 deletion spec/definitions/rails5/core/Integer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ Integer.deprecate:
Integer.descendants:
types:
- undefined
skip: false
skip: true
Integer.duplicable?:
types:
- undefined
Expand Down
2 changes: 1 addition & 1 deletion spec/definitions/rails5/core/String.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ String.deprecate:
String.descendants:
types:
- undefined
skip: false
skip: true
String.duplicable?:
types:
- undefined
Expand Down
2 changes: 1 addition & 1 deletion spec/definitions/rails5/core/Time.yml
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ Time.deprecate:
Time.descendants:
types:
- undefined
skip: false
skip: true
Time.duplicable?:
types:
- undefined
Expand Down
10 changes: 6 additions & 4 deletions spec/solargraph-rails/rails5_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -131,15 +131,17 @@ def change
)
end

it 'auto-completes ActiveSupport core extensions' do
map = use_workspace './spec/rails5'

context 'auto-completes ActiveSupport core extensions' do
Dir
.glob('spec/definitions/rails5/core/*.yml')
.each do |path|
name = File.basename(path).split('.').first

assert_matches_definitions(map, name, "rails5/core/#{name}")
it "core/#{name}" do
map = use_workspace './spec/rails5'

assert_matches_definitions(map, name, "rails5/core/#{name}")
end
end
end
end
10 changes: 6 additions & 4 deletions spec/solargraph-rails/rails6_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -126,15 +126,17 @@ def change
)
end

it 'auto-completes ActiveSupport core extensions' do
map = use_workspace './spec/rails6'

context 'auto-completes ActiveSupport core extensions' do
Dir
.glob('spec/definitions/rails6/core/*.yml')
.each do |path|
name = File.basename(path).split('.').first
name = File.basename(path).split('.').first

it "core/#{name}" do
map = use_workspace './spec/rails6'

assert_matches_definitions(map, name, "rails6/core/#{name}")
end
end
end
end
10 changes: 6 additions & 4 deletions spec/solargraph-rails/rails7_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -130,15 +130,17 @@ def change
)
end

it 'auto-completes ActiveSupport core extensions' do
map = use_workspace './spec/rails7'

context 'auto-completes ActiveSupport core extensions' do
Dir
.glob('spec/definitions/rails7/core/*.yml')
.each do |path|
name = File.basename(path).split('.').first
name = File.basename(path).split('.').first

it "core/#{name}" do
map = use_workspace './spec/rails7'

assert_matches_definitions(map, name, "rails7/core/#{name}")
end
end
end
end

0 comments on commit c7a2dc4

Please sign in to comment.