Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grader is unstable banner might not be seen by the user #1320

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

khattam2
Copy link
Contributor

Fixes #1309

Description

What?

'Grader is unstable' banner might not be seen by the user

Why?

'Grader is unstable' banner might not be seen by the user since it is at the top of the page

How?

Made similar to the ''Course has already ended" banner, that stays at the top of the viewport, while the user scrolls the page.

Testing

image

Remember to add or update unit tests for new features and changes.

What type of test did you run?

  • Accessibility test using the WAVE extension.
  • Django unit tests.
  • Selenium tests.
  • Other test. (Add a description below)
  • Manual testing.

[ADD A DESCRIPTION ABOUT WHAT YOU TESTED MANUALLY]

Did you test the changes in

  • Chrome
  • Firefox
  • This pull request cannot be tested in the browser.

Think of what is affected by these changes and could become broken

Translation

Programming style

  • Did you follow our style guides?
  • Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

  • documents inside the doc directory.
  • README.md.
  • Aplus Manual.
  • Other documentation (mention below which documentation).

Is it Done?

  • Reviewer has finished the code review
  • After the review, the developer has made changes accordingly
  • Customer/Teacher has accepted the implementation of the feature

Clean up your git commit history before submitting the pull request!

Users might not see the alert sometimes, since it was
always at the top of the page.

Fixes apluslms#1309
@ihalaij1 ihalaij1 force-pushed the grader_unstable_banner_update branch from f127fff to 8a87701 Compare January 29, 2024 15:30
Copy link
Contributor

@ihalaij1 ihalaij1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I moved the banner to another HTML file, so that it isn't so wide, because it was covering up the left-hand side navigation menu when scrolling down.

@ihalaij1 ihalaij1 merged commit f032511 into apluslms:master Jan 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

'Grader is unstable' banner might not be seen by the user
2 participants