Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Bootstrap from version 3 to 5. #1442

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

sayravai
Copy link
Contributor

@sayravai sayravai commented Feb 6, 2025

Description

What?

Upgrade of the Bootstrap UI library from version 3 to 5.

Why?

Bootstrap 3 is no longer receiving security or other updates. We thought about migrating to another UI library, but decided to do a version upgrade instead at this time, and look at possible bigger architectural changes later on.

How?

The templates, CSS, and JavaScript have been updated to work with the new Bootstrap version. Although jQuery is no longer required for Bootstrap, there are many other things that use or require it, so migrating off that was not attempted. Some functions were converted to plain JS, though.

Some other things updated/changed in this PR:

  • The Glyphicon font was replaced by Bootstrap icons.
  • The DataTables plugin was upgraded from version 1 to 2.

Things to look into still:

Testing

Remember to add or update unit tests for new features and changes.

What type of test did you run?

  • Accessibility test using the WAVE extension.
  • Django unit tests.
  • Selenium tests.
  • Other test. (Add a description below)
  • Manual testing.

All Playwright tests were updated and ran.

[ADD A DESCRIPTION ABOUT WHAT YOU TESTED MANUALLY]

Did you test the changes in

  • Chrome
  • Firefox
  • This pull request cannot be tested in the browser.

Think of what is affected by these changes and could become broken

Translation

Programming style

  • Did you follow our style guides?
  • Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

  • documents inside the doc directory.
  • README.md.
  • Aplus Manual.
  • Other documentation (mention below which documentation).

Is it Done?

  • Reviewer has finished the code review
  • After the review, the developer has made changes accordingly
  • Customer/Teacher has accepted the implementation of the feature

Clean up your git commit history before submitting the pull request!

assets/js/aplus.js Fixed Show fixed Hide fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

1 participant