[cmake] Install libraries in standard directories #685
+34
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, libraries were installed under `lib/swift/${os}/`. They
should be installed in the default library directory for the relevant
target system.
In addition, swiftmodules were installed in the older layout format on
non-Darwin platforms. This changes to use the standard modern layout
format for swiftmodules.
|
@compnerd Before I get started on other libraries, is this what you had in mind? |
compnerd
reviewed
Nov 20, 2024
Steelskin
force-pushed
the
cmake-install-folders
branch
from
9ea1bc0 to
34f4919
Compare
|
@swift-ci please test |
|
This is going to require a cross-repository test to ensure that the toolchain builds don't break. |
etcwilde
reviewed
Nov 21, 2024
etcwilde
reviewed
Nov 21, 2024
compnerd
reviewed
Jan 28, 2025
compnerd
approved these changes
Jan 29, 2025
|
@swift-ci please test |
etcwilde
reviewed
Jan 29, 2025
I filed https://gitlab.kitware.com/cmake/cmake/-/issues/26649 for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, libraries were installed under
lib/swift/${os}/. They should be installed in the default library directory for the relevant target system.In addition, swiftmodules were installed in the older layout format on non-Darwin platforms. This changes to use the standard modern layout format for swiftmodules.
Checklist