Actually disable hostname validation on Apple platforms when asked #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation:
swift-nio-ssl has long had a flag to disable its own certificate
validation behaviour. This flag works fine, and had the desired
effect.
However, this flag did not take account of the fact that Security.framework
_also_ validates the hostname. Due to an implementation bug,
setting .noHostnameVerification disabled only one of the two checks.
Modifications:
- Correctly check the flag before passing a hostname to
Security.framework
- Write some tests to make sure the behaviour works in all
modes.
Result:
Better, more consistent behaviour.
gjcairo
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
swift-nio-ssl has long had a flag to disable its own certificate validation behaviour. This flag works fine, and had the desired effect.
However, this flag did not take account of the fact that Security.framework also validates the hostname. Due to an implementation bug, setting .noHostnameVerification disabled only one of the two checks.
Modifications:
Result:
Better, more consistent behaviour.