refactor: refactor gRPC client initialization methods

- Remove an empty string parameter from `InitFCMClient` call - Replace `grpc.Dial` with `grpc.NewClient` in health example - Replace `grpc.Dial` with `grpc.NewClient` in send example Signed-off-by: Bo-Yi Wu <[email protected]>
appleboy · Jun 8, 2024 · a20e5be · a20e5be
1 parent 855dddc
commit a20e5be
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/router/server_test.go b/router/server_test.go
@@ -40,7 +40,7 @@ func TestMain(m *testing.M) {
 	cfg.Android.Enabled = true
 	cfg.Android.Credential = os.Getenv("FCM_CREDENTIAL")
 
-	if _, err := notify.InitFCMClient(cfg, ""); err != nil {
+	if _, err := notify.InitFCMClient(cfg); err != nil {
 		log.Fatal(err)
 	}
 

diff --git a/rpc/example/go/health/main.go b/rpc/example/go/health/main.go
@@ -18,7 +18,7 @@ const (
 
 func main() {
 	// Set up a connection to the server.
-	conn, err := grpc.Dial(address, grpc.WithTransportCredentials(insecure.NewCredentials()))
+	conn, err := grpc.NewClient(address, grpc.WithTransportCredentials(insecure.NewCredentials()))
 	if err != nil {
 		log.Fatalf("did not connect: %v", err)
 	}

diff --git a/rpc/example/go/send/main.go b/rpc/example/go/send/main.go
@@ -17,7 +17,7 @@ const (
 
 func main() {
 	// Set up a connection to the server.
-	conn, err := grpc.Dial(address, grpc.WithTransportCredentials(insecure.NewCredentials()))
+	conn, err := grpc.NewClient(address, grpc.WithTransportCredentials(insecure.NewCredentials()))
 	if err != nil {
 		log.Fatalf("did not connect: %v", err)
 	}