fix: use mutable content and content available when set. #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Content available is for background notifications hence the notification shouldn't have an alert or sound. Ref: https://developer.apple.com/documentation/usernotifications/generating-a-remote-notification
|
@appleboy another on related to IOS push notifications on Firebase. |
hchienjo
force-pushed
the
fix/use-content-available-and-mutable-content-params
branch
from
3fe4849 to
ba99369
Compare
hchienjo
force-pushed
the
fix/use-content-available-and-mutable-content-params
branch
from
ba99369 to
ef7ea80
Compare
|
I will take it. |
appleboy
approved these changes
Sep 12, 2024
|
@hchienjo Thanks |
|
Thanks! Is there a plan to tag a new version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the content available and mutable content fields when set. In the older version e.g 1.4.0 and in the legacy FCM API the content available was set here and used here in the request. It would be good for when these fields are set they can be propagated to Firebase Cloud Messaging under the APNS Config section.
The 2 fields influence how Apple Push Notification system handles the notifications on the end user device.
Content available is for background notifications hence the notification shouldn't have an alert or sound according to this reference.