importing test transactions #773

yuunlimm · 2025-01-17T17:44:27Z

Description

Checklist

If any existing pages were renamed or removed:
- Were redirects added to next.config.mjs?
- Did you update any relative links that pointed to the renamed / removed pages?
Do all Lints pass?
- [x ] Have you ran pnpm fmt?
- [x ] Have you ran pnpm lint?

vercel · 2025-01-17T17:44:29Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
developer-docs-nextra	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 23, 2025 9:44pm

yuunlimm · 2025-01-17T17:44:47Z

prepare test transactions #777
testing processor #776
generating test transactions with move script #775
importing test transactions #773 👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

apps/nextra/pages/en/build/indexer/indexer-sdk/documentation/advanced-tutorials.mdx

.../nextra/pages/en/build/indexer/indexer-sdk/documentation/advanced-tutorials/txn-importer.mdx

apps/nextra/pages/en/build/indexer/indexer-sdk/documentation/advanced-tutorials/_meta.tsx

.../nextra/pages/en/build/indexer/indexer-sdk/documentation/advanced-tutorials/txn-importer.mdx

rtso · 2025-01-23T19:15:18Z

.../nextra/pages/en/build/indexer/indexer-sdk/documentation/advanced-tutorials/txn-importer.mdx

+
+### Export the `json_transactions` Folder
+
+Ensure the `json_transactions` folder is properly exported in the library file.


Bit confused about this instruction and the "Export the Generated File" instruction. Do they need to add both to mod.rs?

pub mod generated_transactions; pub mod json_transactions;

first one they need for sure, but the 2nd one could be slightly different. if they already have their own file where they are exporting othe folders they can just add to there. should I just remove that part? I assume they will know how to export files..

Oh is this for generated_transactions to be able to read json_transactions?

Then it makes sense to include pub mod json_transactions in the instructions, but we can add more details to explain why you need to do it and which folder to do it in.

The previous step and this step refer to different repos, so it's a bit confusing to follow.

yeah I will add more details and update the url to use the same repo as teh step above!

rtso · 2025-01-23T19:18:55Z

.../nextra/pages/en/build/indexer/indexer-sdk/documentation/advanced-tutorials/txn-importer.mdx

+### Add as a Dependency
+
+Include the crate containing the generated transactions as a dependency in the `Cargo.toml` file of your test crate. (Internally, we store transactions in `aptos-core` and use them in the [processor repo](https://github.com/aptos-labs/aptos-indexer-processors/blob/0c92d323b0f560b5f8601a831a36520ad9b72d68/rust/Cargo.toml#L34)).


Users have the choice of --output-folder, they could put it in a new crate or existing crate, so I think we can skip this step in this guide.

graphite-app · 2025-01-23T20:07:48Z

.../nextra/pages/en/build/indexer/indexer-sdk/documentation/advanced-tutorials/txn-importer.mdx

+[Example Crate](https://github.com/aptos-labs/aptos-indexer-processor-example/tree/main/test-transactions-example).
+
+## Next Steps
+Once the transaction constants are integrated, you can use them in processor tests to validate functionality. For detailed instructions on writing processor tests, refer to [Writing Processor Tests]().


The link [Writing Processor Tests]() appears to be a placeholder with an empty destination URL. To maintain documentation quality, either add the correct URL for the processor tests documentation or remove the link formatting entirely. This will prevent users from encountering a broken link when following the guide.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

graphite-app · 2025-01-23T20:08:38Z

.../nextra/pages/en/build/indexer/indexer-sdk/documentation/advanced-tutorials/txn-importer.mdx

+### Integrate into Test Cases
+
+Use the exported transaction constants directly in your test cases to simulate real transactions and validate processing logic.
+


Remove or update the broken link 'Writing Processor Tests' at the end of the file. If the documentation doesn't exist yet, remove the reference. If it does exist, update with the correct path.

Spotted by Graphite Reviewer (based on CI logs)

Is this helpful? React 👍 or 👎 to let us know.

rtso · 2025-01-27T21:22:18Z

apps/nextra/pages/en/build/indexer/indexer-sdk/documentation/_meta.tsx

+  "advanced-tutorials": {
+    title: "Advanced Tutorials",
+  },


there's already an Advanced section. can remove this.

yuunlimm marked this pull request as ready for review January 17, 2025 17:45

yuunlimm requested review from a team, gregnazario, hariria and igor-p as code owners January 17, 2025 17:45

graphite-app bot reviewed Jan 17, 2025

View reviewed changes

apps/nextra/pages/en/build/indexer/indexer-sdk/documentation/advanced-tutorials.mdx Outdated Show resolved Hide resolved

vercel bot deployed to Preview January 17, 2025 17:51 View deployment

yuunlimm force-pushed the 01-17-importing_test_transactions branch from 7a25198 to ceacb3f Compare January 17, 2025 18:13

vercel bot deployed to Preview January 17, 2025 18:19 View deployment

This was referenced Jan 17, 2025

generating test transactions with move script #775

Open

testing processor #776

Draft

prepare test transactions #777

Open

rtso reviewed Jan 22, 2025

View reviewed changes

graphite-app bot reviewed Jan 23, 2025

View reviewed changes

apps/nextra/pages/en/build/indexer/indexer-sdk/documentation/advanced-tutorials/_meta.tsx Outdated Show resolved Hide resolved

.../nextra/pages/en/build/indexer/indexer-sdk/documentation/advanced-tutorials/txn-importer.mdx Outdated Show resolved Hide resolved

yuunlimm force-pushed the 01-17-importing_test_transactions branch 4 times, most recently from 51b360e to 0307421 Compare January 23, 2025 18:30

graphite-app bot reviewed Jan 23, 2025

View reviewed changes

.../nextra/pages/en/build/indexer/indexer-sdk/documentation/advanced-tutorials/txn-importer.mdx Outdated Show resolved Hide resolved

yuunlimm force-pushed the 01-17-importing_test_transactions branch from 0307421 to d1e31ef Compare January 23, 2025 18:33

rtso reviewed Jan 23, 2025

View reviewed changes

vercel bot deployed to Preview January 23, 2025 19:31 View deployment

graphite-app bot reviewed Jan 23, 2025

View reviewed changes

vercel bot deployed to Preview January 23, 2025 20:24 View deployment

yuunlimm force-pushed the 01-17-importing_test_transactions branch from 5fd548e to aeacbb0 Compare January 23, 2025 21:16

vercel bot deployed to Preview January 23, 2025 21:21 View deployment

importing test transactions

60db79c

yuunlimm force-pushed the 01-17-importing_test_transactions branch from aeacbb0 to 60db79c Compare January 23, 2025 21:38

vercel bot deployed to Preview January 23, 2025 21:44 View deployment

rtso approved these changes Jan 27, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

importing test transactions #773

importing test transactions #773

yuunlimm commented Jan 17, 2025 •

edited

Loading

vercel bot commented Jan 17, 2025 •

edited

Loading

yuunlimm commented Jan 17, 2025 •

edited

Loading

rtso Jan 23, 2025

yuunlimm Jan 23, 2025

rtso Jan 23, 2025

yuunlimm Jan 23, 2025 •

edited

Loading

rtso Jan 23, 2025

graphite-app bot Jan 23, 2025

graphite-app bot Jan 23, 2025

rtso Jan 27, 2025


		### Export the `json_transactions` Folder

		Ensure the `json_transactions` folder is properly exported in the library file.

		### Add as a Dependency

		Include the crate containing the generated transactions as a dependency in the `Cargo.toml` file of your test crate. (Internally, we store transactions in `aptos-core` and use them in the [processor repo](https://github.com/aptos-labs/aptos-indexer-processors/blob/0c92d323b0f560b5f8601a831a36520ad9b72d68/rust/Cargo.toml#L34)).

		### Integrate into Test Cases

		Use the exported transaction constants directly in your test cases to simulate real transactions and validate processing logic.

importing test transactions #773

Are you sure you want to change the base?

importing test transactions #773

Conversation

yuunlimm commented Jan 17, 2025 • edited Loading

Description

Checklist

vercel bot commented Jan 17, 2025 • edited Loading

yuunlimm commented Jan 17, 2025 • edited Loading

rtso Jan 23, 2025

Choose a reason for hiding this comment

yuunlimm Jan 23, 2025

Choose a reason for hiding this comment

rtso Jan 23, 2025

Choose a reason for hiding this comment

yuunlimm Jan 23, 2025 • edited Loading

Choose a reason for hiding this comment

rtso Jan 23, 2025

Choose a reason for hiding this comment

graphite-app bot Jan 23, 2025

Choose a reason for hiding this comment

graphite-app bot Jan 23, 2025

Choose a reason for hiding this comment

rtso Jan 27, 2025

Choose a reason for hiding this comment

yuunlimm commented Jan 17, 2025 •

edited

Loading

vercel bot commented Jan 17, 2025 •

edited

Loading

yuunlimm commented Jan 17, 2025 •

edited

Loading

yuunlimm Jan 23, 2025 •

edited

Loading