Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(APP-3725): Update Dialog component for 'size' prop #391

Merged
merged 18 commits into from
Jan 23, 2025
Merged

Conversation

thekidnamedkd
Copy link
Contributor

@thekidnamedkd thekidnamedkd commented Jan 22, 2025

Description

Adds size prop to Dialog and DialogAlert -- constrained by max width. Refactors the dialog for backdraw which also constrains max dialog size to top or bottom design spec

Task: APP-3725

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before the
    latest version.

New Checklist:

  • Manually smoke tested the functionality locally
  • Confirmed there are no new warnings or errors in the browser console
  • Made the corresponding changes to the documentation
  • Added tests that prove my fix is effective or that my feature works
  • Updated the CHANGELOG.md file after the [UPCOMING] title and before the latest version
  • (For User Stories only) Double-checked that all Acceptance Criteria are satisified
  • Confirmed there are no new warnings on automated tests
  • Selected the correct base branch
  • Commented the code in hard-to-understand areas
  • Followed the code style guidelines of this project
  • Reviewed that the files changed in GitHub’s UI reflect my intended changes
  • Confirmed the pipeline checks are not failing

@thekidnamedkd thekidnamedkd changed the title WIP feat(APP-3725): Implement Dialog/DialogAlert sizing + responsiveness feat(APP-3725): Implement Dialog/DialogAlert sizing + responsiveness Jan 22, 2025
@thekidnamedkd thekidnamedkd requested a review from a team January 22, 2025 12:38
@thekidnamedkd thekidnamedkd changed the title feat(APP-3725): Implement Dialog/DialogAlert sizing + responsiveness feat(APP-3725): Implement Dialog 'size' prop Jan 22, 2025
@thekidnamedkd thekidnamedkd changed the title feat(APP-3725): Implement Dialog 'size' prop feat(APP-3725): Update Dialog component for 'size' prop + layout Jan 22, 2025
CHANGELOG.md Outdated Show resolved Hide resolved
@thekidnamedkd thekidnamedkd changed the title feat(APP-3725): Update Dialog component for 'size' prop + layout feat(APP-3725): Update Dialog component for 'size' prop Jan 23, 2025
@cgero-eth cgero-eth merged commit 1ab3823 into main Jan 23, 2025
4 checks passed
@cgero-eth cgero-eth deleted the feat/APP-3725 branch January 23, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants