Remove deprecated code in SortUtils #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aprokop
commented
Oct 4, 2024
•
aprokop
commented
- Remove 2D and 3D permutation routines
dalg24
reviewed
Oct 4, 2024
| PermuteHelper::CopyOp<OutputView, InputView>::copy( | ||
| output_view, permutation(i), input_view, i); | ||
| }); | ||
| KOKKOS_LAMBDA(int i) { output_view(permutation(i)) = input_view(i); }); |
There was a problem hiding this comment.
static assert that views are rank-1
What do you mean by type requirements? That the inputs are views? |
aprokop
force-pushed
the
remove_deprecation
branch
from
6b8c35f to
f962ec3
Compare
that they are rank-1 views yes |
dalg24
approved these changes
Oct 9, 2024
Comment on lines
+54
to
+55
| static_assert(InputView::rank == 1); | ||
| static_assert(OutputView::rank == 1); |
There was a problem hiding this comment.
Suggested change
| static_assert(InputView::rank == 1); | |
| static_assert(OutputView::rank == 1); | |
| static_assert(InputView::rank() == 1); | |
| static_assert(OutputView::rank() == 1); |
Comment on lines
+76
to
+77
| static_assert(InputView::rank == 1); | ||
| static_assert(OutputView::rank == 1); |
There was a problem hiding this comment.
Suggested change
| static_assert(InputView::rank == 1); | |
| static_assert(OutputView::rank == 1); | |
| static_assert(InputView::rank() == 1); | |
| static_assert(OutputView::rank() == 1); |
|
Thanks for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.