Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include distributed dir in ArborX target without MPI #1197

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

aprokop
Copy link
Contributor

@aprokop aprokop commented Dec 7, 2024

Currently building against ArborX installed without MPI is broken:

  Imported target "ArborX::ArborX" includes non-existent path

    "<install_dir>/include/ArborX/distributed"

This is because when we don't enable MPI, none of the files from src/distributed are getting installed, so distributed directory in include is not created. This is likely been broken since #1167.

Somehow, our testing did not catch it. There is one build that has MPI off, CUDA-11.0.3-Clang. I don't understand why that one does not fail. In the install, it clearly does not install any files in distributed include. Perhaps, it is not always emitted (like, here).

@aprokop aprokop added the bug Something isn't working label Dec 7, 2024
@dalg24
Copy link
Contributor

dalg24 commented Dec 8, 2024

I am tempted to say to do this instead

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 163291c5..abb6d8ec 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -145,14 +145,8 @@ install(FILES
   ${CMAKE_CURRENT_BINARY_DIR}/ArborXSettings.cmake
   DESTINATION ${CMAKE_INSTALL_DATADIR}/cmake/ArborX )

-if(ARBORX_ENABLE_MPI)
-  install(DIRECTORY ${PROJECT_SOURCE_DIR}/src/ DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/ArborX
-          FILES_MATCHING PATTERN "*.hpp")
-else()
-  install(DIRECTORY ${PROJECT_SOURCE_DIR}/src/ DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/ArborX
-          FILES_MATCHING PATTERN "*.hpp"
-          PATTERN "*Distribut*" EXCLUDE)
-endif()
+install(DIRECTORY ${PROJECT_SOURCE_DIR}/src/ DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/ArborX
+        FILES_MATCHING PATTERN "*.hpp")
 install(DIRECTORY ${PROJECT_BINARY_DIR}/include/ DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/ArborX
         FILES_MATCHING PATTERN "*.hpp")

@aprokop
Copy link
Contributor Author

aprokop commented Dec 11, 2024

I am tempted to say to do this instead

OK, let's try this instead.

@aprokop aprokop merged commit e8d2517 into arborx:master Dec 11, 2024
1 of 2 checks passed
@aprokop aprokop deleted the fix_install_path branch December 11, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants