-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require Kokkos 4.1 #973
Require Kokkos 4.1 #973
Changes from all commits
366ddab
54036fb
0e1f504
275f44a
5e40d5f
bbf5b3e
eb5be7a
c47f38f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ in the environment file. Its value will be prepended along with the service | |
name to the container on start up. | ||
|
||
|
||
You may use multiple compose files to customize your container. For instance, you | ||
You may use multiple compose files to customize your container. For instance, you | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why did you change? This is likely me using two spaces between sentences. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I changed it in a9dba00, before your review, when I needed to force push to fix the incorrect Jenkins links, and was looking for a minor change. |
||
could reproduce the configuration from one of the automated builds by providing | ||
the following a `docker-compose.override.yml` file: | ||
``` | ||
|
@@ -13,6 +13,6 @@ services: | |
build: | ||
args: | ||
- BASE=nvidia/cuda:11.5.2-devel-ubuntu20.04 | ||
- KOKKOS_VERSION=4.0.00 | ||
- KOKKOS_OPTIONS=-DCMAKE_CXX_STANDARD=17 -DKokkos_ENABLE_OPENMP=ON -DKokkos_ENABLE_CUDA=ON -DKokkos_ENABLE_CUDA_LAMBDA=ON -DKokkos_ARCH_SNB=ON -DKokkos_ARCH_VOLTA70=ON | ||
- KOKKOS_VERSION=4.2.00 | ||
- KOKKOS_OPTIONS=-DCMAKE_CXX_STANDARD=17 -DKokkos_ENABLE_OPENMP=ON -DKokkos_ENABLE_CUDA=ON -DKokkos_ARCH_SNB=ON -DKokkos_ARCH_VOLTA70=ON | ||
``` |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,7 +19,6 @@ | |
#include <ArborX_DetailsBatchedQueries.hpp> | ||
#include <ArborX_DetailsCrsGraphWrapperImpl.hpp> | ||
#include <ArborX_DetailsKokkosExtAccessibilityTraits.hpp> | ||
#include <ArborX_DetailsKokkosExtScopedProfileRegion.hpp> | ||
#include <ArborX_DetailsLegacy.hpp> | ||
#include <ArborX_DetailsNode.hpp> | ||
#include <ArborX_DetailsPermutedData.hpp> | ||
|
@@ -32,6 +31,7 @@ | |
#include <ArborX_TraversalPolicy.hpp> | ||
|
||
#include <Kokkos_Core.hpp> | ||
#include <Kokkos_Profiling_ScopedRegion.hpp> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I just realized it is not provided by |
||
|
||
namespace ArborX | ||
{ | ||
|
@@ -93,7 +93,7 @@ class BasicBoundingVolumeHierarchy | |
query(ExecutionSpace const &space, Predicates const &predicates, | ||
CallbackOrView &&callback_or_view, View &&view, Args &&...args) const | ||
{ | ||
KokkosExt::ScopedProfileRegion guard("ArborX::BVH::query_crs"); | ||
Kokkos::Profiling::ScopedRegion guard("ArborX::BVH::query_crs"); | ||
|
||
Details::CrsGraphWrapperImpl:: | ||
check_valid_callback_if_first_argument_is_not_a_view<value_type>( | ||
|
@@ -206,7 +206,7 @@ class BoundingVolumeHierarchy | |
} | ||
else | ||
{ | ||
KokkosExt::ScopedProfileRegion guard("ArborX::BVH::query_crs"); | ||
Kokkos::Profiling::ScopedRegion guard("ArborX::BVH::query_crs"); | ||
|
||
Kokkos::View<int *, MemorySpace> indices( | ||
"ArborX::CrsGraphWrapper::query::indices", 0); | ||
|
@@ -266,7 +266,7 @@ BasicBoundingVolumeHierarchy<MemorySpace, Value, IndexableGetter, | |
|
||
Details::check_valid_space_filling_curve<DIM>(curve); | ||
|
||
KokkosExt::ScopedProfileRegion guard("ArborX::BVH::BVH"); | ||
Kokkos::Profiling::ScopedRegion guard("ArborX::BVH::BVH"); | ||
|
||
if (empty()) | ||
{ | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,6 @@ | |
#define ARBORX_MINIMUM_SPANNING_TREE_HPP | ||
|
||
#include <ArborX_AccessTraits.hpp> | ||
#include <ArborX_DetailsKokkosExtScopedProfileRegion.hpp> | ||
#include <ArborX_DetailsKokkosExtViewHelpers.hpp> | ||
#include <ArborX_DetailsMinimumSpanningTree.hpp> | ||
#include <ArborX_DetailsMutualReachabilityDistance.hpp> | ||
|
@@ -22,6 +21,9 @@ | |
#include <ArborX_DetailsWeightedEdge.hpp> | ||
#include <ArborX_LinearBVH.hpp> | ||
|
||
#include <Kokkos_Core.hpp> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OK |
||
#include <Kokkos_Profiling_ScopedRegion.hpp> | ||
|
||
namespace ArborX::Details | ||
{ | ||
|
||
|
@@ -230,7 +232,7 @@ struct MinimumSpanningTree | |
edges_start, edges_end); | ||
else | ||
{ | ||
KokkosExt::ScopedProfileRegion guard( | ||
Kokkos::Profiling::ScopedRegion guard( | ||
"ArborX::MST::compute_vertex_parents"); | ||
assignVertexParents(space, labels, component_out_edges, edges_mapping, | ||
bvh, dendrogram_parents); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not bump
4.0.00
to4.1.00
and4.1.00
to4.2.00
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we would leap frog the versions. Change 4.0 to 4.2 now, change 4.1 to 4.3 next time. This way we have a mix of older builds and newer builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For
SYCL
in particular I would prefer using the most recent release. Otherwise, I don't have a strong opinion.