Fix crashing validation check (#65)

archesproject · Feb 14, 2025 · 87b8dd0 · 87b8dd0
1 parent b9c25d6
commit 87b8dd0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/arches_controlled_lists/datatypes/datatypes.py b/arches_controlled_lists/datatypes/datatypes.py
@@ -75,7 +75,9 @@ def validate(
             return [self.transform_exception(e)]
         return []
 
-    def validate_pref_labels(self, references: list[Reference]):
+    def validate_pref_labels(self, references: list[Reference] | None):
+        if not references:
+            return
         for reference in references:
             pref_label_languages = [
                 label.language_id
@@ -87,6 +89,8 @@ def validate_pref_labels(self, references: list[Reference]):
                 raise ValueError(msg)
 
     def validate_multivalue(self, parsed, node, nodeid):
+        if not parsed:
+            return
         if not node:
             if not nodeid:
                 raise ValueError

diff --git a/tests/reference_datatype_tests.py b/tests/reference_datatype_tests.py
@@ -91,6 +91,10 @@ def test_validate(self):
         errors = reference.validate(value=[data], node=mock_node)
         self.assertEqual(errors, [])
 
+        # None is always valid.
+        errors = reference.validate(value=None, node=mock_node)
+        self.assertEqual(errors, [])
+
         # Too many references
         errors = reference.validate(value=[data, data], node=mock_node)
         self.assertEqual(len(errors), 1, errors)