Rename arches-references to arches-controlled-lists #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't forget to update README.md |
johnatawnclementawn
force-pushed
the
jmc/rename-app
branch
from
0a4abcf to
89f9cfe
Compare
jacobtylerwalls
requested changes
Feb 13, 2025
arches_controlled_lists/src/arches_controlled_lists/components/tree/AddDeleteControls.vue
Outdated
Show resolved
Hide resolved
johnatawnclementawn
force-pushed
the
jmc/rename-app
branch
from
89f9cfe to
522f394
Compare
arches_controlled_lists/src/arches_controlled_lists/components/ControlledListsMain.vue
Outdated
Show resolved
Hide resolved
johnatawnclementawn
force-pushed
the
jmc/rename-app
branch
from
522f394 to
6469d83
Compare
jacobtylerwalls
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Looks good!
One thing to consider adding at your option:
- although git is good at ignoring the straight file name renames, we can avoid polluting the git blame for every other inline change by adding this commit hash to a .git-blame-ignore-revs file the same way core does.
- to do this, you'll need the final hash, so do it afterward in a follow-up PR if you plan to squash or rebase merge. if you do it now, then use a merge commit. If you do a follow-up PR it might be a good opportunity to re-run updateproject.
|
That said, most of these are just imports changes, it would only be the 0002 migration where I can imagine looking up the blame, so feel free to ignore this time, can always do it later 👍 |
jacobtylerwalls
requested changes
Feb 13, 2025
jacobtylerwalls
approved these changes
Feb 13, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.