Add ability to exchange reference datatype by list_item_id #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
commented
Feb 12, 2025
Comment on lines
165
to
173
| # Pre-process to discard display values generated by to_representation(). | ||
| pre_processed_values = [] | ||
| for single_value in value: | ||
| if isinstance(single_value, dict) and ( | ||
| list_item_id := single_value.get("list_item_id") | ||
| ): | ||
| pre_processed_values.append(list_item_id) | ||
| else: | ||
| pre_processed_values.append(single_value) |
There was a problem hiding this comment.
This probably belongs in the serialization layer instead of here, but I'm just getting a first iteration out to unblock folks.
jacobtylerwalls
force-pushed
the
jtw/make-serializer-change
branch
from
8a854b0 to
305aec2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes change discussed in planning earlier today. (Pull from the core arches branch!)
Adds ability to write back an array of list item ids for a reference datatype. I didn't bother to remove the code that permitted sending back the entire tile value.
Reads now give you an array of the following objects:
You can even post back that representation without changing it, and the display_value will be discarded.
Partner Lingo PR: archesproject/arches-lingo#213