Add search result details component #11
Open
+187
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apeters
reviewed
Jan 20, 2025
Comment on lines
74
to
84
| <template #item="image"> | ||
| <div class="border border-surface-200 dark:border-surface-700 rounded m-2 p-4"> | ||
| <div class="mb-4"> | ||
| <div class="relative mx-auto"> | ||
| <div style="padding: 3px"> | ||
| <img :src="image.data" height="120px" width="120px" class="w-full rounded" /> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </template> |
apeters
reviewed
Jan 20, 2025
| function selectResult(resourceid: string) { | ||
| resultSelected.value = ""; |
There was a problem hiding this comment.
this line is unneeded if you're setting the value in the next line
apeters
reviewed
Jan 20, 2025
| @@ -15,13 +16,19 @@ const props = defineProps({ | |||
| }, | |||
| }); | |||
|
|
|||
| function highlightResult(resourceid: string) { | |||
| if (!resultSelected.value) { | |||
| resultsSelected.value = []; | |||
There was a problem hiding this comment.
I don't think you need to assign an empty array if in the next line you're reassigning to a different array.
|
There's several build errors when running "build_development" that should be easy fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a component to display a simple report when a user select 'show more' in search result item. It is also displayed in lieu of a pop-up when a user clicks a feature on the map.