Skip to content

Commit

Permalink
Show effect of vue/html-self-closing rule re #172
Browse files Browse the repository at this point in the history
  • Loading branch information
jacobtylerwalls committed Jan 3, 2025
1 parent e8f9a00 commit 3992349
Show file tree
Hide file tree
Showing 13 changed files with 24 additions and 23 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ defineEmits(["update"]);
<div v-if="mode === VIEW">
<ControlledListItemViewer :value="value" />
</div>
<div v-if="mode === EDIT"></div>
<div v-if="mode === EDIT" />
</div>
</template>
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ function confirmDelete(tileId: string) {
<ConfirmDialog
:pt="{ root: { style: { fontFamily: 'sans-serif' } } }"
:group="metaStringText.name"
></ConfirmDialog>
/>
<div v-if="props.metaStrings?.length">
<DataTable
v-model:expanded-rows="expandedRows"
Expand All @@ -65,7 +65,7 @@ function confirmDelete(tileId: string) {
<slot
name="name"
:row-data="slotProps.data"
></slot>
/>
</template>
</Column>
<Column
Expand All @@ -76,7 +76,7 @@ function confirmDelete(tileId: string) {
<slot
name="type"
:row-data="slotProps.data"
></slot>
/>
</template>
</Column>
<Column
Expand All @@ -87,7 +87,7 @@ function confirmDelete(tileId: string) {
<slot
name="language"
:row-data="slotProps.data"
></slot>
/>
</template>
</Column>
<Column>
Expand Down Expand Up @@ -124,7 +124,7 @@ function confirmDelete(tileId: string) {
<slot
name="drawer"
:row-data="slotProps.data"
></slot>
/>
</div>
</template>
</DataTable>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ const items = ref([
<i
:class="item.icon"
aria-hidden="true"
></i>
/>
<span style="font-weight: var(--p-button-label-font-weight)">
{{ item.label }}
</span>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -145,17 +145,15 @@ function editSectionValue(tileId: string) {
(rowData as AppellativeStatus)
.appellative_status_ascribed_relation
"
>
</ControlledListItem>
/>
</template>
<template #language="{ rowData }">
<ControlledListItem
:value="
(rowData as AppellativeStatus)
.appellative_status_ascribed_name_language
"
>
</ControlledListItem>
/>
</template>
<template #drawer="{ rowData }">
<div>
Expand All @@ -165,7 +163,7 @@ function editSectionValue(tileId: string) {
(rowData as AppellativeStatus)
.appellative_status_data_assignment_object_used
"
></ResourceInstanceRelationships>
/>
</div>
<div>
<span>{{ $gettext("Contributors:") }}</span>
Expand All @@ -174,7 +172,7 @@ function editSectionValue(tileId: string) {
(rowData as AppellativeStatus)
.appellative_status_data_assignment_actor
"
></ResourceInstanceRelationships>
/>
</div>
</template>
</MetaStringViewer>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ function onNamespaceNameUpdate(val: string) {
<Button
:label="$gettext('Update')"
@click="save"
></Button>
/>
</div>
</div>
</template>
Original file line number Diff line number Diff line change
Expand Up @@ -162,5 +162,5 @@ function editSectionValue(tileId: string) {
</MetaStringViewer>
</SchemeReportSection>
</div>
<div v-if="mode === EDIT"></div>
<div v-if="mode === EDIT" />
</template>
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ const props = defineProps<{
<Button
:label="$gettext(`Add ${props.titleText}`)"
@click="$emit(OPEN_EDITOR)"
></Button>
/>
</div>
</div>
<div class="content">
<slot></slot>
<slot />
</div>
</div>
</template>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,6 @@ function onCreationUpdate(val: string[]) {
<Button
:label="$gettext('Update')"
@click="save"
></Button>
/>
</div>
</template>
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const items = ref([
<i
:class="item.icon"
aria-hidden="true"
></i>
/>
</RouterLink>
</div>
</aside>
Expand Down
4 changes: 2 additions & 2 deletions arches_lingo/src/arches_lingo/components/tree/TreeRow.vue
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ const toggleFocus = (node: TreeNode) => {

<template>
<!-- eslint-disable vue/no-v-html -->
<span v-html="rowLabel(node.data)"></span>
<span v-html="rowLabel(node.data)" />
<!-- eslint-enable vue/no-v-html -->
<i
v-tooltip="{
Expand All @@ -76,5 +76,5 @@ const toggleFocus = (node: TreeNode) => {
:style="{ alignSelf: 'center', marginLeft: '1rem' }"
@click="toggleFocus(node)"
@keyup.enter="toggleFocus(node)"
></i>
/>
</template>
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,6 @@ const greeting = computed(() => {
<Button
:label="$gettext('Sign out')"
@click="issueLogout"
></Button>
/>
</div>
</template>
2 changes: 1 addition & 1 deletion arches_lingo/src/arches_lingo/pages/LoginPage.vue
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import LoginLinks from "@/arches_lingo/components/login/LoginLinks.vue";
<template>
<div class="login-container">
<LoginForm />
<div class="spacer"></div>
<div class="spacer" />
<LoginLinks />
</div>
</template>
Expand Down
3 changes: 3 additions & 0 deletions eslint.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ export default [
},
"rules": {
"semi": ["error", "always"],
"vue/html-self-closing": [
"error", { "html": { "void": "any" } }
],
},
},
];

0 comments on commit 3992349

Please sign in to comment.