Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relocate Controlled List Manager and Reference Datatype #1

Merged
merged 36 commits into from
Jul 30, 2024
Merged

Relocate Controlled List Manager and Reference Datatype #1

merged 36 commits into from
Jul 30, 2024

Conversation

johnatawnclementawn
Copy link
Member

@johnatawnclementawn
Init arches_references project
9facde0
@johnatawnclementawn
Isolate controlled list manager into separate Arches App
81a6608
@johnatawnclementawn
Avoid repeating word "controlled" in new models
98edc1c
@johnatawnclementawn
Move frontend from core Arches archesproject/arches#11209
efa30f5
@johnatawnclementawn
Add datatype tests for reference datatype re. archesproject/arches#11209
c299f8f
@johnatawnclementawn
Sync frontend names after backend serialization changes
d964b88
@johnatawnclementawn
Remove dependency on ArchesTestCase
02a339d
@johnatawnclementawn
Exclude controlled lists tests from packaging
4e3ce64
@johnatawnclementawn
Move and update packages commands for controlled lists
1057344
@johnatawnclementawn
Move and update controlled list and reference datatype tests
053debe
@johnatawnclementawn
Fix directory structure issue caused by project init in wrong directory
5317aed
@johnatawnclementawn
Fix frontend dependency imports to arches-references
1fb1447
@johnatawnclementawn
Fix import
ddfd019
@johnatawnclementawn
Fix migration dependency
647f5f7
@johnatawnclementawn
Paramaterize export controlled list filename
feb67a3
@johnatawnclementawn
Move and cleanup arches_references tests
efd80fa
@johnatawnclementawn
Add 7.6 compatibility
5d2c2ba
@johnatawnclementawn
nit
93c7010
@johnatawnclementawn
Add index on node configuration
a8220b7
@johnatawnclementawn
Subclass django TestCase rather than ArchesTestCase
f9d12c9
@johnatawnclementawn
Temp override primevue back to 3.53
ed8bcc8
@johnatawnclementawn
Adjust CLM frontend namespacing
925c7c0
@johnatawnclementawn
revert frontend namespacing and fix CLM frontend imports
45d8f28
@johnatawnclementawn
Move theme.ts to project for workaround until primevue 4
f50978e
@johnatawnclementawn
nit file extension
5419e02
@johnatawnclementawn
Migrate CLM translations and urls
7a1e572
@johnatawnclementawn
nit
9fa562a
@johnatawnclementawn
Update arches-references to latest arches_urls pattern in arhces/dev/…
e071ac9 
…7.6.x
@johnatawnclementawn
De-alias arches ts type imports for happier path on front-end build
a85de9a
@johnatawnclementawn
Black formatting nits
9e49f19
jacobtylerwalls
jacobtylerwalls requested changes Jul 29, 2024
View reviewed changes
Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, just a few nits.

Re: the vitest failure, I'm okay punting for a few days if need be. Would be nice to get this merged and be able to raise the next set of PRs that are waiting on it.

arches_references/tests/test_settings.py Outdated Show resolved Hide resolved
arches_references/templates/javascript.htm Outdated Show resolved Hide resolved
MANIFEST.in Outdated Show resolved Hide resolved
tests/search_indexes/__init__.py Outdated Show resolved Hide resolved
jacobtylerwalls
jacobtylerwalls approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@johnatawnclementawn
Copy link
Member Author

Target branch tests failing because it's a blank repo

@johnatawnclementawn johnatawnclementawn merged commit 7102ecb into main Jul 30, 2024
5 of 6 checks passed
@johnatawnclementawn johnatawnclementawn deleted the jmc/relocate_clm_and_reference_dt branch July 30, 2024 15:03
@jacobtylerwalls jacobtylerwalls mentioned this pull request Jul 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobtylerwalls jacobtylerwalls jacobtylerwalls approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnatawnclementawn @jacobtylerwalls