Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate URIs when not supplied #8 #17

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Generate URIs when not supplied #8 #17

merged 2 commits into from
Jul 30, 2024

Conversation

jacobtylerwalls
Copy link
Member

Closes #8

robgaston
robgaston approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@robgaston robgaston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes look good to me and behave as expected

@robgaston robgaston merged commit db5e7f0 into main Jul 30, 2024
6 checks passed
@johnatawnclementawn johnatawnclementawn deleted the jtw/generate-uri branch July 30, 2024 21:54
@jacobtylerwalls jacobtylerwalls mentioned this pull request Jul 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robgaston robgaston robgaston approved these changes

@johnatawnclementawn johnatawnclementawn Awaiting requested review from johnatawnclementawn

Assignees

@robgaston robgaston

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[controlled-lists] Reference select widget assumes items have URIs
2 participants
@jacobtylerwalls @robgaston