-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typescript problems #22
Conversation
5c848a0
to
f385734
Compare
f385734
to
5f130a5
Compare
@chrabyrd Would you happen to know why vitest is failing here? It's passing on arches-lingo but only because the dummy test declarations is not found there (it's under src/). Here it's failing harder (the file is under src/arches_references). |
Yes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Fix typescript problems exposed after latest pushes to dev/7.6.x
Closes #21
Take this opportunity to simplify types and not mix
string | number
for new items versus existing items; just check instead whether something looks like a UUID to tell if it exists on the server.