Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typescript problems #22

Merged
merged 11 commits into from
Aug 9, 2024
Merged

Fix typescript problems #22

merged 11 commits into from
Aug 9, 2024

Conversation

jacobtylerwalls
Copy link
Member

Fix typescript problems exposed after latest pushes to dev/7.6.x

Closes #21

Take this opportunity to simplify types and not mix string | number for new items versus existing items; just check instead whether something looks like a UUID to tell if it exists on the server.

@jacobtylerwalls
Copy link
Member Author

@chrabyrd Would you happen to know why vitest is failing here? It's passing on arches-lingo but only because the dummy test declarations is not found there (it's under src/). Here it's failing harder (the file is under src/arches_references).

@chrabyrd
Copy link
Contributor

chrabyrd commented Aug 9, 2024

@chrabyrd Would you happen to know why vitest is failing here? It's passing on arches-lingo but only because the dummy test declarations is not found there (it's under src/). Here it's failing harder (the file is under src/arches_references).

Yes. declarations.d.ts hasn't been updated, it still has

import("../../node_modules/arches/arches/app/src/declarations.d.ts");

Copy link
Contributor

@chrabyrd chrabyrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jacobtylerwalls jacobtylerwalls merged commit 6157b3c into main Aug 9, 2024
5 of 6 checks passed
@jacobtylerwalls jacobtylerwalls deleted the jtw/fix-ts-problems branch August 9, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix typescript issues after latest arches 7.6
2 participants