Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cnh/remove parent concept 11741 #11742

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Conversation

chiatt
Copy link
Member

@chiatt chiatt commented Jan 22, 2025

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Prevents the front end from sending a parent concept to be added, when the intent is to remove a relationship to that parent concept.

Issues Solved

Closes #11741

Checklist

  • I targeted one of these branches:
    • dev/8.0.x (under development): features, bugfixes not covered below
    • dev/7.6.x (main support): regressions, crashing bugs, security issues, major bugs in new features
    • dev/6.2.x (extended support): major security issues, data loss issues
  • I added a changelog in arches/releases
  • I submitted a PR to arches-docs (if appropriate)
  • Unit tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • My test fails on the target branch

Accessibility Checklist

Developer Guide

Topic Changed Retested
Color contrast
Form fields
Headings
Links
Keyboard
Responsive Design
HTML validation
Screen reader

Ticket Background

  • Sponsored by:
  • Found by: @
  • Tested by: @
  • Designed by: @

Further comments

@chiatt chiatt changed the base branch from dev/8.0.x to dev/7.6.x January 22, 2025 23:18
@chiatt chiatt requested a review from apeters January 22, 2025 23:18
Copy link
Member

@apeters apeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@apeters apeters merged commit e549443 into dev/7.6.x Jan 23, 2025
7 checks passed
@apeters apeters deleted the cnh/remove_parent_concept_11741 branch January 23, 2025 01:53
chiatt added a commit that referenced this pull request Jan 23, 2025
@chiatt chiatt mentioned this pull request Jan 23, 2025
8 tasks
apeters added a commit that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to remove a parent concept in the RDM
2 participants