Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

12 cbyrd update settings from afs cleanup #15

Merged
merged 3 commits into from
Sep 20, 2023
Merged

12 cbyrd update settings from afs cleanup #15

merged 3 commits into from
Sep 20, 2023

Conversation

chrabyrd
Copy link
Contributor

@chrabyrd chrabyrd commented Sep 20, 2023 •
edited
Loading

@chrabyrd chrabyrd mentioned this pull request Sep 20, 2023
Merged
jacobtylerwalls
jacobtylerwalls reviewed Sep 20, 2023
View reviewed changes
Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, just one DX suggestion. tested with the sister PR for afs, and site boots, nothing amiss.

disco/settings.py Outdated Show resolved Hide resolved
@chrabyrd chrabyrd merged commit 77c7a69 into main Sep 20, 2023
@chrabyrd chrabyrd deleted the 12-cbyrd-update-settings-from-afs-cleanup branch September 20, 2023 21:22
@chrabyrd chrabyrd mentioned this pull request Sep 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobtylerwalls jacobtylerwalls jacobtylerwalls left review comments

Assignees

@jacobtylerwalls jacobtylerwalls

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrabyrd @jacobtylerwalls