Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds XY renderer #16

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Adds XY renderer #16

merged 2 commits into from
Sep 28, 2023

Conversation

aarongundel
Copy link
Collaborator

We'd probably be better served by saving these renderers in the DB instead of in config. That'll be a core change.

This depends on archesproject/arches-for-science#1287

@aarongundel aarongundel requested a review from chiatt September 20, 2023 22:02
@aarongundel aarongundel linked an issue Sep 27, 2023 that may be closed by this pull request
Two-Dimensional (Spectral) Digital Data Loader archesproject/arches-for-science#1218
Closed
chiatt
chiatt approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@chiatt chiatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chiatt chiatt merged commit b9280e5 into main Sep 28, 2023
@chiatt chiatt deleted the afs_1218_xy_reader branch September 28, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiatt chiatt chiatt approved these changes

Assignees

@chiatt chiatt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Two-Dimensional (Spectral) Digital Data Loader
2 participants
@aarongundel @chiatt