Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create logs directory #22

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Create logs directory #22

merged 2 commits into from
Oct 23, 2023

Conversation

jacobtylerwalls
Copy link
Member

Ensure the logs directory is created when checking out the repo.

Prevents this failure in the CSV importer:

File "/web_root/arches/arches/app/utils/data_management/resources/importer.py", line 247, in import_business_data
    reader.report_errors()
  File "/web_root/arches/arches/app/utils/data_management/resources/formats/format.py", line 212, in report_errors
    f = open(settings.RESOURCE_IMPORT_LOG, "w")
FileNotFoundError: [Errno 2] No such file or directory: '/web_root/disco/disco/logs/resource_import.log'

Also small cleanup following #21.

Prevents failure of csv importer
Copy link
Collaborator

@aarongundel aarongundel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ironically, I just ran into this issue on Friday within the USD project. Thanks for fixing here.

@jacobtylerwalls jacobtylerwalls merged commit d8677f5 into main Oct 23, 2023
@jacobtylerwalls jacobtylerwalls deleted the create-log-dir branch October 23, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants