Divide rate with 100

Needed for the calculation to be correct according to the documentation. `$money->addTax(20)` and not `$money->addTax(0.2)`
archtechx · Dec 28, 2021 · 356aad9 · 356aad9
1 parent 8ca2124
commit 356aad9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/Money.php b/src/Money.php
@@ -115,7 +115,7 @@ public function divideBy(float $number): self
     public function addFee(float $rate): self
     {
         return $this->multiplyBy(
-            round(1 + $rate, $this->currency->mathDecimals())
+            round(1 + ($rate / 100), $this->currency->mathDecimals())
         );
     }
 
@@ -129,7 +129,7 @@ public function addTax(float $rate): self
     public function subtractFee(float $rate): self
     {
         return $this->divideBy(
-            round(1 + $rate, $this->currency->mathDecimals())
+            round(1 + ($rate / 100), $this->currency->mathDecimals())
         );
     }
 

diff --git a/tests/Pest/MoneyTest.php b/tests/Pest/MoneyTest.php
@@ -104,19 +104,19 @@
 test('fees can be added to and subtracted from money', function () {
     $money = Money::fromDecimal(10.0);
 
-    expect($money->addFee(0.1)->decimal())->toBe(11.0);
-    expect($money->subtractFee(0.1)->decimal())->toBe(9.09); // 10/1.1
+    expect($money->addFee(10)->decimal())->toBe(11.0);
+    expect($money->subtractFee(10)->decimal())->toBe(9.09); // 10/1.1
 });
 
 test('taxes can be added and subtracted from money', function () {
     currencies()->add([CZK::class]);
 
     expect(
-        Money::fromDecimal(100.0, 'CZK')->addTax(0.21)->decimal()
+        Money::fromDecimal(100.0, 'CZK')->addTax(21.0)->decimal()
     )->toBe(121.0);
 
     expect(
-        Money::fromDecimal(121.0, 'CZK')->subtractTax(0.21)->decimal()
+        Money::fromDecimal(121.0, 'CZK')->subtractTax(21.0)->decimal()
     )->toBe(100.0);
 });