Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #9 #10

Closed
wants to merge 2 commits into from
Closed

Fixes #9 #10

wants to merge 2 commits into from

Conversation

dalholm
Copy link
Contributor

@dalholm dalholm commented Dec 30, 2021

No description provided.

@stancl
Copy link
Member

stancl commented Dec 30, 2021

Thanks for the PR. I think I'll implement this myself in a few weeks, when I'll be adding some other features.

I wouldn't specifically add $rate here, I'd have a general override support that handles arrays etc. So I'll find the ideal implementation when I work on this 👍🏻

@stancl stancl closed this Dec 30, 2021
@gauravmak
Copy link
Contributor

Related Issue - #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dalholm @stancl @gauravmak