fix(in-cluster): do not allow the cluster to be used when disabled

[agaudreault]

Closes #21207

The ApplicationSet code is still using the in-cluster, even when disabled. However, the apps will fail in Argo CD, which is expected. See #10473

Depends on #21225

Existing applications:

New applications creation (API):

[bunnyshell]

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

• 🔵 /bns:start to start the environment
• 🚀 /bns:deploy to redeploy the environment
• ❌ /bns:delete to remove the environment

[codecov]

Codecov Report

Attention: Patch coverage is 73.52941% with 9 lines in your changes missing coverage. Please review.

Project coverage is 53.29%. Comparing base (ef55ba5) to head (9bd1f1f).
Report is 9 commits behind head on master.

Files with missing lines	Patch %	Lines
util/db/cluster.go	73.52%	6 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #21208      +/-   ##
==========================================
- Coverage   55.17%   53.29%   -1.89%     
==========================================
  Files         337      337              
  Lines       57057    57076      +19     
==========================================
- Hits        31483    30416    -1067     
- Misses      22870    24010    +1140     
+ Partials     2704     2650      -54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rumstead]

Could you fix the linting errors? It seems that there is a race condition being caught. The stack traces look like a similar problem I fixed before - https://github.com/argoproj/argo-cd/pull/20805/files

[terrytangyuan]

Good catch. Thanks!

[agaudreault]

Cherry pick in 2.13 will require #20805 and #21225

[ishitasequeira]

The changes LGTM
@agaudreault can you fix the CI failures?

[agaudreault]

Current documentation seems to indicate that this setting is to disable the cluster. In every other cases, the behavior when a cluster is removed is for the apps to go in the unknown status and prevent sync from an invalid destination.

Removing a cluster

Run argocd cluster rm context-name.

This removes the cluster with the specified name.

!!!note "in-cluster cannot be removed"
The in-cluster cluster cannot be removed with this. If you want to disable the in-cluster configuration, you need to update your argocd-cm ConfigMap. Set cluster.inClusterEnabled to "false"

[agaudreault]

@ishitasequeira @terrytangyuan @rumstead lint/test fixed. Let's wait for discussion on the issue to know if we should cherry-pick.

Thanks for the review!

[crenshaw-dev]

lgtm besides a few nitpicks. One final suggestion would be to change the tests to tabular tests for readability. Will go with your decision on whether that's worth the time.

[rumstead]

Overall LGTM