Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove legacy repo support (#19768) #21249

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

crenshaw-dev
Copy link
Member

@crenshaw-dev crenshaw-dev commented Dec 18, 2024

Closes #19768

TODO:

  • docs
  • make sure I haven't lost important test coverage

Copy link

bunnyshell bot commented Dec 18, 2024

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Signed-off-by: Michael Crenshaw <[email protected]>
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 55.34%. Comparing base (ef55ba5) to head (929c695).
Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
util/db/repository.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21249      +/-   ##
==========================================
+ Coverage   55.17%   55.34%   +0.16%     
==========================================
  Files         337      336       -1     
  Lines       57057    56388     -669     
==========================================
- Hits        31483    31208     -275     
+ Misses      22870    22537     -333     
+ Partials     2704     2643      -61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Michael Crenshaw <[email protected]>
@crenshaw-dev crenshaw-dev changed the title chore!: remove legacy repo support (#19678) chore!: remove legacy repo support (#19768) Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for legacy argocd-cm repo config
1 participant